Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds product search query without simulation #73

Closed
wants to merge 7 commits into from
Closed

Adds product search query without simulation #73

wants to merge 7 commits into from

Conversation

vwraposo
Copy link
Contributor

@vwraposo vwraposo commented Nov 1, 2019 •
edited
Loading

What is the purpose of this pull request?

Depends on vtex-apps/search-graphql#27

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 1, 2019 •
edited by vwraposo
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation

jgfidelis
jgfidelis suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@jgfidelis jgfidelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove facets arges from no simulation query

react/queries/productSearchNoSimulations.gql Outdated
$priceRange: String
$from: Int
$to: Int
$withFacets: Boolean = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg not needed

react/queries/productSearchNoSimulations.gql Outdated
query search(
$query: String
$map: String
$facetQuery: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg not needed

react/queries/productSearchNoSimulations.gql Outdated
$query: String
$map: String
$facetQuery: String
$facetMap: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg not needed

@vwraposo vwraposo requested a review from jgfidelis November 6, 2019 13:33
@jgfidelis jgfidelis force-pushed the feature/query-wo-simulation branch from 823a184 to c54be78 Compare November 7, 2019 13:39
@jgfidelis jgfidelis force-pushed the feature/query-wo-simulation branch from c54be78 to 52f70df Compare November 21, 2019 19:53
@vwraposo vwraposo closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfidelis jgfidelis jgfidelis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwraposo @jgfidelis